test: Re-enable guarddog tests which were accidentally disabled due to a parameterized test mishap.#6462
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Apr 2, 2019
Conversation
…o a parameterized test mishap. Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
reviewed
Apr 2, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Do we have an issue tracking deflaking these tests? If so can you link to it in comments or in PR?
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
approved these changes
Apr 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Prior to final review in #6369 I made the test base-class parameterized to run it both with simulated time and real time. I was actually surprised to find that real-time tests worked in tsan 1000x. It was too good to be true. SimulatedTime is very robust but some of the real-time tests don't work.
I found when looking at coverage that some of the guarddog code wasn't being run in tests which surprised me, because I knew we should have coverage.
So this PR parametarizes all the test-classes, not just the base-class, getting the coverage back.
Risk Level: low
Testing: just this test, but with/without tsan and --runs_per_test=1000
Docs Changes: n/a
Release Notes: n/a