Skip to content

Docs and tests: Struct deprecation for Any and hosts deprecation for load_assignment #6409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moderation wants to merge 13 commits into from
Closed

Docs and tests: Struct deprecation for Any and hosts deprecation for load_assignment #6409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b0d6eab
Docs and sandboxes: Remove reference to Docker Machine, fix sandbox c…
moderation Mar 20, 2019
89bab5a
Standardize on pulling fresh images before launching containers.
moderation Mar 20, 2019
02ad9d2
Explicitly add DNS for Docker containers for edge case where host mac…
moderation Mar 21, 2019
c132c98
Standardize on upcase E for Envoy in the docs.
moderation Mar 21, 2019
f43b900
Text formatting fixes.
moderation Mar 21, 2019
1d15d33
Merge remote-tracking branch 'upstream/master'
moderation Mar 21, 2019
86a1615
Merge remote-tracking branch 'upstream/master'
moderation Mar 21, 2019
58a19fb
Merge remote-tracking branch 'upstream/master'
moderation Mar 22, 2019
2e0627b
Docs: Update examples for Struct deprecation for Any
moderation Mar 23, 2019
87cd0fb
Merge remote-tracking branch 'upstream/master'
moderation Mar 24, 2019
9a8cc18
Standardize on double quote for @type declarations.
moderation Mar 26, 2019
d403a2d
Merge remote-tracking branch 'upstream/master'
moderation Mar 27, 2019
2e1db2d
Docs and tests: Struct deprecation for Any and hosts deprecation for …
moderation Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions api/XDS_PROTOCOL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,15 @@ static_resources:
- name: ads_cluster
connect_timeout: { seconds: 5 }
type: STATIC
hosts:
- socket_address:
address: <ADS management server IP address>
port_value: <ADS management server port>
load_assignment:
cluster_name: ads_cluster
Copy link
Member

@htuch htuch Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should make cluster_name optional for these embedded scenarios? This information is strictly redundant. @dio @mattklein123 ?

Copy link
Member

@dio dio May 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htuch do you think this does make sense?

Copy link
Member

@htuch htuch May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dio sort of. I think we can do this today by removing the check from PGV and putting it in Envoy at the consuming sites. I'm not sure how to do it generically though, ideas?

endpoints:
- lb_endpoints:
- endpoint:
address:
socket_address:
address: <ADS management server IP address>
port_value: <ADS management server port>
lb_policy: ROUND_ROBIN
http2_protocol_options: {}
upstream_connection_options:
Expand Down
6 changes: 4 additions & 2 deletions docs/root/configuration/network_filters/zookeeper_proxy_filter.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ in the configuration snippet below:
filter_chains:
- filters:
- name: envoy.filters.network.zookeeper_proxy
config:
typed_config:
"@type": type.googleapis.com/envoy.config.filter.network.zookeeper_proxy.v1alpha1.ZooKeeperProxy
stat_prefix: zookeeper
- name: envoy.tcp_proxy
config:
typed_config:
"@type": type.googleapis.com/envoy.config.filter.network.tcp_proxy.v2.TcpProxy
stat_prefix: tcp
cluster: ...

Expand Down
18 changes: 12 additions & 6 deletions docs/root/faq/configure_flow_control.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,13 @@ the only one which needs to be amended is the listener
name: http
address:
socketAddress:
address: '::1'
address: ::1
portValue: 0
filterChains:
filters:
name: envoy.http_connection_manager
config:
typed_config:
"@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
http2_protocol_options:
initial_stream_window_size: 65535
route_config: {}
Expand All @@ -59,7 +60,12 @@ the only one which needs to be amended is the listener
name: cluster_0
connectTimeout: 5s
perConnectionBufferLimitBytes: 1024
hosts:
socketAddress:
address: '::1'
portValue: 46685
load_assignment:
cluster_name: cluster_0
endpoints:
- lb_endpoints:
- endpoint:
address:
socket_address:
address: ::1
port_value: 46685
13 changes: 11 additions & 2 deletions test/config/integration/google_com_proxy_port_0.v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ static_resources:
filter_chains:
- filters:
- name: envoy.http_connection_manager
config:
typed_config:
"@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
stat_prefix: ingress_http
codec_type: AUTO
route_config:
Expand All @@ -33,4 +34,12 @@ static_resources:
# Comment out the following line to test on v6 networks
dns_lookup_family: {{ dns_lookup_family }}
lb_policy: ROUND_ROBIN
hosts: [{ socket_address: { address: google.com, port_value: 443 }}]
load_assignment:
cluster_name: service_google
endpoints:
- lb_endpoints:
- endpoint:
address:
socket_address:
address: google.com
port_value: 443
Loading