Skip to content

router: remove route-action level header manipulation#6408

Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
derekargueta:dereka/4616-deprecation
Apr 1, 2019
Merged

router: remove route-action level header manipulation#6408
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
derekargueta:dereka/4616-deprecation

Conversation

@derekargueta
Copy link
Member

Description: These features were deprecated in #3838 and resolves #4616
Risk Level: Low (may break anyone who is still using route-action header add/removal)
Testing: Updated - route-action configs were either removed or bumped to the route level
Docs Changes: N/A - documentation was already removed when deprecated.
Release Notes: Added

Signed-off-by: Derek Argueta dereka@pinterest.com

Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
@derekargueta
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

🙀 failed invoking rebuild of ci/circleci: release: 500 Internal Server Error

🐱

Caused by: a #6408 (comment) was created by @derekargueta.

see: more, trace.

@lizan lizan requested a review from junr03 March 28, 2019 13:59
@mattklein123 mattklein123 self-assigned this Mar 28, 2019
@mattklein123
Copy link
Member

@derekargueta do you mind merging master?

/wait

@derekargueta
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: coverage (failed build)
🔨 rebuilding ci/circleci: compile_time_options (failed build)
🔨 rebuilding ci/circleci: asan (failed build)

🐱

Caused by: a #6408 (comment) was created by @derekargueta.

see: more, trace.

@derekargueta
Copy link
Member Author

hmmm, //test/extensions/transport_sockets/alts:alts_integration_test failed on that last run.

@derekargueta
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: compile_time_options (failed build)

🐱

Caused by: a #6408 (comment) was created by @derekargueta.

see: more, trace.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattklein123 mattklein123 merged commit 26d3aaf into envoyproxy:master Apr 1, 2019
@derekargueta derekargueta deleted the dereka/4616-deprecation branch April 1, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v1.8.0 (Oct 4, 2018) deprecation] Remove features marked deprecated in #3838

3 participants