stats: Plumb through symbol tables everywhere. Pulled from #6161.#6299
Merged
jmarantz merged 8 commits intoenvoyproxy:masterfrom Mar 19, 2019
Merged
stats: Plumb through symbol tables everywhere. Pulled from #6161.#6299jmarantz merged 8 commits intoenvoyproxy:masterfrom
jmarantz merged 8 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
changed the title
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
requested changes
Mar 17, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Looks good just 1 question and 1 nit. Thanks and very excited to see all of this pay off!
/wait
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…stats().symbolTable(). Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
jmarantz
added a commit
to jmarantz/envoy
that referenced
this pull request
Mar 20, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR is intended to be a large but trivial and safe refactor, to plumb SymbolTable wherever it will be needed in #6161 and ultimately #4980 . Those PRs have some complexity and areas to watch for performance and contentions, so it will be pretty hard to review them if they are also very large. This is ultimately trying to resolve #4196 .
Risk Level: low - pure refactor
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a