Plumb BoolIndicator through stats sink and admin#6279
Closed
taion809 wants to merge 3 commits intoenvoyproxy:masterfrom
Closed
Plumb BoolIndicator through stats sink and admin#6279taion809 wants to merge 3 commits intoenvoyproxy:masterfrom
taion809 wants to merge 3 commits intoenvoyproxy:masterfrom
Conversation
Fixes: envoyproxy#6277 Signed-off-by: Nicholas J <nicholas.a.johns5@gmail.com>
Signed-off-by: Nicholas J <nicholas.a.johns5@gmail.com>
Member
Contributor
Author
|
SGTM, i'm currently working on tests right but but I agree if it's easier to revert we should do that so prod deployments dont get blocked |
Member
Member
Contributor
Author
|
SGTM, one thing to consider though is that when outputting the metrics statsd and prometheus both have no boolean datatype, they need to be converted to an int and output as a gauge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Description: Plumb the boolIndicators through various stats sinks and handlers. This also needs to cast from bool to int for collectors like statsd and prometheus.
Risk Level: Low
Testing: Manual testing
Fixes: #6277
Signed-off-by: Nicholas J nicholas.a.johns5@gmail.com