Conversation
1) Add partial consumption 2) Fix ceiling math for next wakeup time 3) Minor cleanups Needed for #5942 Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@ramaraochavali PTAL |
ramaraochavali
previously approved these changes
Mar 10, 2019
Contributor
ramaraochavali
left a comment
ramaraochavali
left a comment
There was a problem hiding this comment.
LGTM, expect one minor nit and one question
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Mar 11, 2019
* master: token bucket: several fixes (envoyproxy#6235) config: move logging of full response to trace logging (envoyproxy#6226) mysql_filter: add a warning about compatibility (envoyproxy#6234) upstream: add transport socket failure reason to stream info and log (envoyproxy#6018) IoHandle readv and writev (envoyproxy#6037) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #5942
Risk Level: Low
Testing: New UT
Docs Changes: N/A
Release Notes: N/A