main_common_test: workaround for libevent TSAN failures.#6200
Merged
htuch merged 4 commits intoenvoyproxy:masterfrom Mar 7, 2019
Merged
main_common_test: workaround for libevent TSAN failures.#6200htuch merged 4 commits intoenvoyproxy:masterfrom
htuch merged 4 commits intoenvoyproxy:masterfrom
Conversation
This is needed to unblock envoyproxy#6196 while libevent/libevent#741 (and consequently envoyproxy#6083) go unresolved. It's not particularly wonderful, but it will allow us to make progress independent of the libevent work. Risk level: Low Testing: TSAN runs with envoyproxy#6196. Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
reviewed
Mar 7, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Looks good with small question.
dnoe
reviewed
Mar 7, 2019
mattklein123
approved these changes
Mar 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to unblock #6196 while
libevent/libevent#741 (and consequently
#6083) go unresolved.
It's not particularly wonderful, but it will allow us to make progress independent of the libevent
work.
Risk level: Low
Testing: TSAN runs with #6196.
Signed-off-by: Harvey Tuch htuch@google.com