build: use foreign_cc for luajit#6168
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
@htuch while marking this as draft this is ready for removing LuaJIT prebuilt part, let me know whether you want to include removing all envoy_deps stuff in the same PR or a different one. |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM, this is great. Nuke all the old prebuilt, Envoy deps and other machinery for build recipes, I'm so happy to see it go!
|
This is so exciting. I agree, please kill all the old infra. Lots to delete. |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
@htuch this should be good to go. |
Remove the last prebuilt dependencies and switches to foreign_cc with a slight wrapper script. Risk Level: Low Testing: CI Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Follow up of #6168. Risk Level: Low Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Migration from the build recipes to foreign_cc rules resulted
in dependencies being built with different compiler flags.
Among other things, those compiler flags were added:
-ffunction-sections -fdata-sections
use of which leads to LuaJIT panicking:
PANIC: unprotected error in call to Lua API
and Envoy subsequently crashing.
Broken in envoyproxy#6168.
Fixes istio/istio#13722.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Migration from the build recipes to foreign_cc rules resulted
in dependencies being built with different compiler flags.
Among other things, those compiler flags were added:
-ffunction-sections -fdata-sections
use of which leads to LuaJIT panicking:
PANIC: unprotected error in call to Lua API
and Envoy subsequently crashing.
Broken in #6168.
Fixes istio/istio#13722.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Migration from the build recipes to foreign_cc rules resulted
in dependencies being built with different compiler flags.
Among other things, those compiler flags were added:
-ffunction-sections -fdata-sections
use of which leads to LuaJIT panicking:
PANIC: unprotected error in call to Lua API
and Envoy subsequently crashing.
Broken in envoyproxy#6168.
Fixes istio/istio#13722.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
| + os.environ["MACOSX_DEPLOYMENT_TARGET"] = "10.6" | ||
| + os.environ["DEFAULT_CC"] = os.environ.get("CC", "") | ||
| + os.environ["TARGET_CFLAGS"] = os.environ.get("CFLAGS", "") | ||
| + os.environ["TARGET_LDFLAGS"] = os.environ.get("CFLAGS", "") |
There was a problem hiding this comment.
@lizan Is this intentional or just a bug carried over?
Isn't TARGET_LDFLAGS supposed to be overridden by os.environ.get("LDFLAGS")
was TARGET_LDFLAGS=${CFLAGS} just to address that MacOSX bug mentioned in old code comment?
There was a problem hiding this comment.
Hmm, not sure, this is just to replicate what we had in luajit.sh.
What is the macOS bug, the MACOSX_DEPLOYMENT_TARGET one is not relevant to this environment variable.
There was a problem hiding this comment.
The
- MACOSX_DEPLOYMENT_TARGET=10.6 DEFAULT_CC=${CC} TARGET_CFLAGS=${CFLAGS} TARGET_LDFLAGS=${CFLAGS}
Was the first place where TARGET_LDFLAGS was overridden with CFLAGS, and I think this small mistake was carried over in
+ os.environ["TARGET_LDFLAGS"] = os.environ.get("CFLAGS", "")
4 participants
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Remove the last prebuilt dependencies and switches to foreign_cc with a slight wrapper script.
Risk Level: Low
Testing: CI
Docs Changes:
Release Notes: