Move IoError interface from Network to Api namespace#6104
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Feb 28, 2019
greenhouse-org:move-io-error
Merged
Move IoError interface from Network to Api namespace#6104mattklein123 merged 3 commits intoenvoyproxy:masterfrom greenhouse-org:move-io-error
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
greenhouse-org:move-io-error
Conversation
Signed-off-by: Yael Harel <yharel@pivotal.io> Signed-off-by: Sam Smith <sesmith177@gmail.com>
Member
|
@danzh2010 PTAL |
include/envoy/api/io_error.h
Outdated
| }; | ||
|
|
||
| using IoCallBoolResult = IoCallResult<bool>; | ||
| using IoCallSizeResult = IoCallResult<ssize_t>; |
Member
There was a problem hiding this comment.
It seems that IoCallBoolResult and IoCallSizeResult types are unused. I'd drop them off.
Contributor
Author
There was a problem hiding this comment.
They're left overs from #6072. I'll remove them.
Signed-off-by: Sam Smith <sesmith177@gmail.com> Signed-off-by: Yael Harel <yharel@pivotal.io>
dnoe
reviewed
Feb 28, 2019
dnoe
approved these changes
Feb 28, 2019
Contributor
dnoe
left a comment
dnoe
left a comment
There was a problem hiding this comment.
Thanks again for splitting this up - much easier to review this way.
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Yael Harel <yharel@pivotal.io> Signed-off-by: Sam Smith <sesmith177@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR is broken out from #6072.
Risk Level:
Low
Testing:
bazel build //source/... && bazel test //test/...
Docs Changes:
N/A
Release Notes:
N/A
cc @jmarantz @dnoe