Include a python script to print Envoy's dependencies#6049
Merged
htuch merged 3 commits intoenvoyproxy:masterfrom Feb 27, 2019
Merged
Include a python script to print Envoy's dependencies#6049htuch merged 3 commits intoenvoyproxy:masterfrom
htuch merged 3 commits intoenvoyproxy:masterfrom
Conversation
Contributor
Author
|
Signed-off on the commits. |
Contributor
jmillikin-stripe
left a comment
jmillikin-stripe
left a comment
There was a problem hiding this comment.
This looks reasonable overall. I have one comment about a potential dependency from data-plane-api/ to envoy/ that we might need to break before merging.
Contributor
Author
|
Sounds good - I had that before but forgot about that dependency this time
around.
…On Mon, Feb 25, 2019 at 13:02 jmillikin-stripe ***@***.***> wrote:
***@***.**** commented on this pull request.
This looks reasonable overall. I have one comment about a potential
dependency from data-plane-api/ to envoy/ that we might need to break
before merging.
------------------------------
In api/bazel/repositories.bzl
<#6049 (comment)>:
> ***@***.***_tools//tools/build_defs/repo:http.bzl", "http_archive")
***@***.***//bazel:envoy_http_archive.bzl", "envoy_http_archive")
This is adding a dependency from the Envoy API to the main Envoy source
tree, which I believe is not desirable (it would make
https://github.com/envoyproxy/data-plane-api much less useful as a
lightweight dependency).
Can you move or copy envoy_http_archive.bzl into api/bazel/?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6049 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABIgrn2qfSyUzE4dDyFLAIWsIuWgkRTks5vRCUxgaJpZM4bQEpw>
.
|
lizan
reviewed
Feb 27, 2019
htuch
previously approved these changes
Feb 27, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks for the contribution and driving this PR to a super clean implementation.
Member
|
@dprotaso ready to merge, but needs DCO fix :D |
this is now used by the api package Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
This will enable extracting out version details Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
htuch
approved these changes
Feb 27, 2019
Merged
lizan
added a commit
that referenced
this pull request
Mar 5, 2019
Description: Fixes merge race with #6049. Risk Level: Low Testing: Docs Changes: Release Notes: Signed-off-by: Lizan Zhou <lizan@tetrate.io>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
The python script will print a machine readable output of Envoy's external dependencies ./tools/print_dependencies.py I opt'd not to include the bazel rule this time around. Risk Level: Low Testing: I tested the changes by invoking the script `ci/build_container/docker_build.sh` Signed-off-by: Dave Protasowski <dprotaso@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Description: Fixes merge race with envoyproxy#6049. Risk Level: Low Testing: Docs Changes: Release Notes: Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworking of an existing PR - #5049
Description:
The python script will print a machine readable output of Envoy's external dependencies
I opt'd not to include the bazel rule this time around.
Risk Level: Low
Testing:
I tested the changes by invoking the script
ci/build_container/docker_build.shDocs Changes:
None
Release Notes:
None