Skip to content

ci: add QUIC to bazel.compile_time_options. #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizan merged 2 commits into from
Feb 13, 2019
Merged

ci: add QUIC to bazel.compile_time_options. #5926

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b78fb5
ci: add QUIC to bazel.compile_time_options.
PiotrSikora Feb 12, 2019
1915c8f
review: add TODO.
PiotrSikora Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/do_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ elif [[ "$1" == "bazel.compile_time_options" ]]; then
--define boringssl=fips \
--define log_debug_assert_in_release=enabled \
--define tcmalloc=debug \
--define quiche=enabled \

@mattklein123 mattklein123 Feb 12, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this define do? Doesn't this just get enabled automatically when the QUIC listener extension is compiled?

@mpwarres mpwarres Feb 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this controls whether QUIC listener-related tests are built and run. The short history is that QUICHE platform code requires a Bazel bugfix flag (--experimental_remap_main_repo) to be set in order to successfully link with Envoy libraries, so @htuch suggested that we avoid building QUICHE by default (at least, until the flag becomes default behavior), to avoid poor developer experience. Since then, the Bazel flag has been enabled in the default .bazelrc (#5767), so it should be ok to enable compilation/testing of QUICHE here, though we probably still do not want to set quiche=enabled for developer local builds.

Tagging @wu-bin and @danzh2010 , just as a heads up.

@mattklein123 mattklein123 Feb 12, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK makes sense. Can we add a TODO comment here that we eventually want to remove this from compile_time_options and have this be part of the standard build?

@PiotrSikora PiotrSikora Feb 12, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO added (for you, @mpwarres, hope that's OK).

@mpwarres mpwarres Feb 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO added (for you, @mpwarres, hope that's OK).

Yup, SGTM

"
setup_clang_toolchain
# This doesn't go into CI but is available for developer convenience.
Expand Down