socket_option: don't set socket IP socket options on pipes.#5870
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Feb 7, 2019
Merged
socket_option: don't set socket IP socket options on pipes.#5870htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12293. Risk level: Low Testing: Corpus entry and unit test added. Signed-off-by: Harvey Tuch <htuch@google.com>
venilnoronha
reviewed
Feb 7, 2019
| if (addr->ip() != nullptr) { | ||
| return addr->ip()->version(); | ||
| } | ||
| throw EnvoyException("Unable to set socket option on non-IP sockets"); |
Member
There was a problem hiding this comment.
Should this method throw a more generic EnvoyException, followed by setOption throwing this one?
Member
Author
There was a problem hiding this comment.
This is caught in getVersionFromSocket() and converted to a nullopt return.
Member
There was a problem hiding this comment.
I just felt that the exception message didn't match the function's operation.
Member
Author
There was a problem hiding this comment.
Yeah, technically it doesn't, but I don't think it's a big deal given the hyper local use here.
mattklein123
approved these changes
Feb 7, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…xy#5870) Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12293. Risk level: Low Testing: Corpus entry and unit test added. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12293.
Risk level: Low
Testing: Corpus entry and unit test added.
Signed-off-by: Harvey Tuch htuch@google.com