Shift test_base library to testonly+basic_cc_library.#5865
Merged
htuch merged 5 commits intoenvoyproxy:masterfrom Feb 8, 2019
Merged
Shift test_base library to testonly+basic_cc_library.#5865htuch merged 5 commits intoenvoyproxy:masterfrom
htuch merged 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Randy Smith <rdsmith@google.com>
Contributor
Author
|
@jmarantz , could you take a look? |
Contributor
|
this looks fine especially if it passes CI :) |
Contributor
Author
|
Picky, picky :-}. |
added 2 commits
February 6, 2019 18:01
Contributor
Author
|
Closing this for the moment--it isn't solving the problem I thought it would downstream, and I need to put some more thought in. I may re-open. |
Signed-off-by: Randy Smith <rdsmith@google.com>
Signed-off-by: Randy Smith <rdsmith@google.com>
jmarantz
approved these changes
Feb 7, 2019
htuch
approved these changes
Feb 8, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Mark //test/test_common:test_base testonly for environments that enforce that bit. Risk Level: Low: Build change, any errors should be quick to surface. Testing: Built all of envoy. Signed-off-by: Randy Smith <rdsmith@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Randy Smith rdsmith@google.com
Description: Mark //test/test_common:test_base testonly for environments that enforce that bit.
Risk Level: Low: Build change, any errors should be quick to surface.
Testing: Built all of envoy.
Docs Changes: None.
Release Notes: n/a