api: fix wrong java_package option in a proto file#5853
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Feb 6, 2019
Merged
api: fix wrong java_package option in a proto file#5853mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Penn (Dapeng) Zhang <zdapeng@google.com>
Contributor
Author
Yes. It was copied from the other file, so it has that option when the file was created. check_format only checks if the option is there. fix_format was not triggered. We could add a check, which will disallow custom value. |
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Penn (Dapeng) Zhang <zdapeng@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Penn (Dapeng) Zhang zdapeng@google.com
Description:
The
java_packageoption inapi/envoy/config/common/tap/v2alpha/common.protowas wrong and conflicts with the other fileapi/envoy/service/tap/v2alpha/common.proto.Risk Level: Low
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]