Skip to content

fuzz: avoid leaking time system singleton. #5850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmarantz merged 4 commits into from
Feb 6, 2019
Merged

fuzz: avoid leaking time system singleton. #5850

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76790a5
fuzz: avoid leaking time system singleton.
htuch Feb 5, 2019
be1f062
RELEASE_ASSERT.
htuch Feb 5, 2019
5b564ef
Undo RELEASE_ASSERT, jmarantz@ will fix the implied fails.
htuch Feb 5, 2019
1780602
Scope stats.
htuch Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/fuzz/main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ int main(int argc, char** argv) {
for (size_t i = 0; i < Envoy::test_corpus_.size(); ++i) {
argv[i + 1] = argv[i + 1 + input_args];
}
// Cleanup before we jump into the tests, the test API creates a singleton time system that we
// don't want to leak into gtest.
api.reset();

@jmarantz jmarantz Feb 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. You could also put the entire stanza above into a helper function or a scope.


testing::InitGoogleTest(&argc, argv);
Envoy::Fuzz::Runner::setupEnvironment(argc, argv, spdlog::level::info);
Expand Down