test: Make the creation of a test time system threadsafe#5849
Merged
jmarantz merged 6 commits intoenvoyproxy:masterfrom Feb 7, 2019
Merged
test: Make the creation of a test time system threadsafe#5849jmarantz merged 6 commits intoenvoyproxy:masterfrom
jmarantz merged 6 commits intoenvoyproxy:masterfrom
Conversation
I am not aware of a situation where we might race the creation of our thread-system singleton between two threads, but it's not that hard or slow to make that work. So it seems easier to do this proactively than to wait for a flake. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
reviewed
Feb 5, 2019
… and use std::unique_ptr for the functor to create TimeSystems. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
requested changes
Feb 6, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM just some nits.
/wait
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
approved these changes
Feb 7, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…5849) * Make the creation of a test time system threadsafe. I am not aware of a situation where we might race the creation of our thread-system singleton between two threads, but it's not that hard or slow to make that work. So it seems easier to do this proactively than to wait for a flake. Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: I am not aware of a situation where we might race the creation of our thread-system singleton between two threads, but it's not that hard or slow to make that work. So it seems easier to do this proactively than to wait for a flake. Also removes a flaky contention test that failed in CI on this PR.
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a