Merged
Conversation
Due to the external_cmake changes (amongst others), we've regressed on the fuzzer build. We need to do the final link now inside the cc_binary, as external_cmake has issues with transitivity and unrelated binaries (see bazel-contrib/rules_foreign_cc#222). Risk level: Low Testing: oss-fuzz Docker build for Envoy's fuzzers. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
to htuch/oss-fuzz
that referenced
this pull request
Feb 5, 2019
Envoy should build again once envoyproxy/envoy#5843 and this merge. Signed-off-by: Harvey Tuch <htuch@google.com>
This was referenced Feb 5, 2019
snowp
approved these changes
Feb 5, 2019
| name = name + "_driverless", | ||
| copts = envoy_copts("@envoy", test = True), | ||
| linkopts = envoy_test_linkopts(), | ||
| linkopts = ["-lFuzzingEngine"] + envoy_test_linkopts(), |
Contributor
There was a problem hiding this comment.
So will -lFuzzingEngine no longer be passed by the oss-fuzz build? We only set it here?
jonathanmetzman
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Feb 5, 2019
Envoy should build again once envoyproxy/envoy#5843 and this merge. Signed-off-by: Harvey Tuch <htuch@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Due to the external_cmake changes (amongst others), we've regressed on the fuzzer build. We need to do the final link now inside the cc_binary, as external_cmake has issues with transitivity and unrelated binaries (see bazel-contrib/rules_foreign_cc#222). Risk level: Low Testing: oss-fuzz Docker build for Envoy's fuzzers. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the external_cmake changes (amongst others), we've regressed on
the fuzzer build. We need to do the final link now inside the cc_binary,
as external_cmake has issues with transitivity and unrelated binaries
(see bazel-contrib/rules_foreign_cc#222).
Risk level: Low
Testing: oss-fuzz Docker build for Envoy's fuzzers.
Signed-off-by: Harvey Tuch htuch@google.com