Disable quic_platform_test by default. Take 2.#5838
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Feb 5, 2019
Merged
Conversation
Signed-off-by: Bin Wu <wub@google.com>
Contributor
Author
|
/assign @mpwarres |
mpwarres
approved these changes
Feb 5, 2019
Contributor
mpwarres
left a comment
mpwarres
left a comment
There was a problem hiding this comment.
LGTM
Sidenote: it appears that in copying the description from #5791 to this PR, the link to the original issue got stripped. Here it is, just for context: #5767 (comment)
alyssawilk
reviewed
Feb 5, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
cool, thanks for exempting this by default
unfortunately I'm, having desktop access isssues so lazy question - do we have this on for at least one of the CI builds?
Contributor
Author
No, I think we want to disable it in CI builds before this issue is fixed. WDYT? |
htuch
approved these changes
Feb 5, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Disable quic_platform_test by default. Enable it only when "--define quiche=enabled" is specified in the bazel command line. This is needed to workaround a issue with --experimental_remap_main_repo + ci asan build, see here for details. Risk Level: minimal: build only Testing: I introduced a failure in quic_platform_test, then confirmed quic_platform_test still passes by default(since it does nothing), and failed when "--define enable_quiche=enabled" is specified. Signed-off-by: Bin Wu <wub@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Disable quic_platform_test by default. Enable it only when "--define quiche=enabled" is specified in the bazel command line.
This is needed to workaround a issue with --experimental_remap_main_repo + ci asan build, see here for details.
Risk Level: minimal: build only
Testing:
I introduced a failure in quic_platform_test, then confirmed quic_platform_test still passes by default(since it does nothing), and failed when "--define enable_quiche=enabled" is specified.
Docs Changes: none
Release Notes: none
[Optional Fixes #Issue]
[Optional Deprecated:]