test: Add a note explaining in more detail the current and potential benefits of a common TestBase class.#5837
Merged
jmarantz merged 2 commits intoenvoyproxy:masterfrom Feb 5, 2019
Conversation
…ts of a common TestBase class. Signed-off-by: Joshua Marantz <jmarantz@google.com>
alyssawilk
approved these changes
Feb 4, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Awesome, thanks for both the explanation and the warning :-)
mattklein123
approved these changes
Feb 4, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…ts of a common TestBase class. (envoyproxy#5837) Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The existing TestBase class-comment needed more detail on what we currently do with it and what could be done with it in the future. Also it needed a warning not to do anything compute-intensive.
Risk Level: very low -- just a comment change.
Testing: none -- rolling the dice with CI
Docs Changes: n/a
Release Notes: n/a