Add quic_client_stats_impl.h to QUICHE platform implementation#5832
Add quic_client_stats_impl.h to QUICHE platform implementation#5832alyssawilk merged 5 commits intoenvoyproxy:masterfrom
Conversation
everything being no-op. Signed-off-by: Bin Wu <wub@google.com>
|
/assign @mpwarres |
test/extensions/quic_listeners/quiche/platform/quic_platform_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Bin Wu <wub@google.com>
Signed-off-by: Bin Wu <wub@google.com>
|
/retest |
|
🔨 rebuilding |
| enum class TestEnum { ZERO = 0, ONE, TWO, COUNT }; | ||
|
|
||
| TEST(QuicPlatformTest, QuicClientStats) { | ||
| // Just make sure they compile. |
There was a problem hiding this comment.
On functions where we're not implementing the actual functionality, should we have comments or a document somewhere for what expect to work and what not?
There was a problem hiding this comment.
We can 1) add comments to quic_client_stats_impl.h, 2) add a column to the platform impl tracking spreadsheet to say it's not actually implemented.
Or both? WDYT?
There was a problem hiding this comment.
I'd mildly prefer something in the code just so folks don't have to dig up the spreadsheet but as long as we're tracking it I'm good :-)
There was a problem hiding this comment.
Added a comment in quic_client_stats_impl.h.
|
Please merge master to pick up #5827. |
…ent_stats Signed-off-by: Bin Wu <wub@google.com>
Signed-off-by: Bin Wu <wub@google.com>
Done. |
…proxy#5832) Add quic_client_stats_impl.h to QUICHE platform implementation, with everything being no-op. _Risk Level_: minimal: code not used yet _Testing_: bazel test test/extensions/quic_listeners/quiche/platform:quic_platform_test --test_output=all _Docs Changes_: none _Release Notes_: none Signed-off-by: Bin Wu <wub@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
4 participants
Description:
Add quic_client_stats_impl.h to QUICHE platform implementation, with everything being no-op.
Risk Level: minimal: code not used yet
Testing: bazel test test/extensions/quic_listeners/quiche/platform:quic_platform_test --test_output=all
Docs Changes: none
Release Notes: none
[Optional Fixes #Issue]
[Optional Deprecated:]