Fix setReference() call in hystrix stats sink#5815
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Feb 3, 2019
Merged
Fix setReference() call in hystrix stats sink#5815mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Per: https://github.com/envoyproxy/envoy/blob/master/include/envoy/http/header_map.h#L148 `setReference()` needs a std::string ref that will live beyond the lifetime of a request/response, but it's currently receiving a string literal which is used to construct a temporary std::string. So instead pass a static std::string. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
rgs1
changed the title
Member
Author
mattklein123
requested changes
Feb 3, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for the fix. Small comment.
/wait
| response_headers.insertAccessControlAllowOrigin().value().setReference( | ||
| Http::Headers::get().AccessControlAllowOriginValue.All); | ||
| response_headers.insertNoChunks().value().setReference("0"); | ||
| response_headers.insertNoChunks().value().setReference(zeroValue()); |
Member
There was a problem hiding this comment.
I'm guessing that calling setInteger(0) here would be both faster and simpler to read.
Member
Author
There was a problem hiding this comment.
Ah yes, thanks for the quick review!
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Per: https://github.com/envoyproxy/envoy/blob/master/include/envoy/http/header_map.h#L148 `setReference()` needs a std::string ref that will live beyond the lifetime of a request/response, but it's currently receiving a string literal which is used to construct a temporary std::string. So instead pass an integer. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per:
https://github.com/envoyproxy/envoy/blob/master/include/envoy/http/header_map.h#L148
setReference()needs a std::string ref that will live beyondthe lifetime of a request/response, but it's currently receiving
a string literal which is used to construct a temporary
std::string.
So instead pass a static std::string.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com