stats: add usedonly option to prometheus output format#5805
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Feb 1, 2019
Merged
stats: add usedonly option to prometheus output format#5805mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
…e been changed Signed-off-by: Suhail Patel <me@suhailpatel.com>
Signed-off-by: Suhail Patel <me@suhailpatel.com>
Signed-off-by: Suhail Patel <me@suhailpatel.com>
Signed-off-by: Suhail Patel <me@suhailpatel.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Suhail Patel <me@suhailpatel.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Adds support for the
usedonlyflag when outputting Prometheus stats. This will omit metrics which have never been updated by Envoy.Risk Level: Low
Testing: Added a few more unit tests to the admin side to ensure it works as intended
Docs Changes: Added a small sentence in the documentation about the
usedonlyflagRelease Notes: Added a release note item to version_history
We've been running with this at Monzo over the past couple days and it has drastically cut down on the sheer volume of metrics from each Envoy instance.