config: explicitly indicate when tcp_proxy deprecated_v1 value field is empty#5794
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Feb 1, 2019
Conversation
…is empty
Given a filter config {"deprecated_v1":true}, Envoy errors out with a cryptic message
about an invalid schema at lines 0-0. This also happens if the required value field
contains an empty object of if value is misspelled (including when it contains
non-printing characters). This change produces a better error message (and adds
tests for the config parsing).
*Risk Level*: low
*Testing*: added unit test
*Docs Changes*: n/a
*Release Notes*: n/a
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Member
Author
|
(I just spent several days going back and forth off-list with a user who ended up having non-printing characters embedded in their config YAML's "value:" key. Something email+copy/paste helpfully stripped the offending character on my end. Hilarity ensued.) |
venilnoronha
approved these changes
Jan 31, 2019
Member
venilnoronha
left a comment
venilnoronha
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the usability upgrade!
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…is empty (envoyproxy#5794) Given a filter config {"deprecated_v1":true}, Envoy errors out with a cryptic message about an invalid schema at lines 0-0. This also happens if the required value field contains an empty object of if value is misspelled (including when it contains non-printing characters). This change produces a better error message (and adds tests for the config parsing). *Risk Level*: low *Testing*: added unit test *Docs Changes*: n/a *Release Notes*: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a filter config
{"deprecated_v1":true}, Envoy errors out with a cryptic messageabout invalid JSON at lines 0-0. This also happens if the required value field
contains an empty object or if value is misspelled (including when it contains
non-printing characters). This change produces a better error message (and adds
tests for the config parsing).
Risk Level: low
Testing: added unit test
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Stephan Zuercher zuercher@gmail.com