code clarity: replace HC with health check#5785
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Feb 1, 2019
Merged
code clarity: replace HC with health check#5785mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
mattklein123
requested changes
Jan 31, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Sounds good to me, please check docs build and a nit around spelling. Thank you!
/wait
Member
There was a problem hiding this comment.
Please be consistent everywhere around "health check" (no dash, space between words). Applies elsewhere.
Contributor
Author
There was a problem hiding this comment.
ok, i will do that
knightXun
force-pushed
the
docs
branch
4 times, most recently
from
417487c to
bdfbabf
Compare
knightXun
changed the title
Signed-off-by: knightXun <100481562@qq.com>
mattklein123
changed the title
mattklein123
changed the title
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: knightXun <100481562@qq.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace HC with health-check, make it easy understand