Modified docs and variable names#5776
Conversation
Signed-off-by: Randy Smith <rdsmith@google.com>
Signed-off-by: Randy Smith <rdsmith@google.com>
Signed-off-by: Randy Smith <rdsmith@google.com>
Signed-off-by: Randy Smith <rdsmith@google.com>
Signed-off-by: Randy Smith <rdsmith@google.com>
|
I think this addition was @htuch so he may be able to vouch for renaming better than I |
| }); | ||
|
|
||
| pre_worker_start_test_steps_ = [this]() { | ||
| server_init_coroutines_ = [this]() { |
There was a problem hiding this comment.
Not a fan of coroutine, since that makes me think of Go. Can we call it on_server_init_fr_, unless you do intend to invoke some kind of concurrency idea due to the coordinating role these routines play?
There was a problem hiding this comment.
fr_? framework? Whatever we go with can we spell out?
There was a problem hiding this comment.
+1 to Alyssa's comment--I'm happy to change the name, but I want to understand the meaning of the name I'm changing it to :-}.
There was a problem hiding this comment.
Sorry, should have been on_server_init_fn_!
There was a problem hiding this comment.
My days of character-limited FORTRAN being long gone, I'm still going to argue for function_ :-P
|
Please merge master to pick up #5827. |
Signed-off-by: Randy Smith <rdsmith@google.com>
Signed-off-by: Randy Smith <rdsmith@google.com>
Signed-off-by: Randy Smith <rdsmith@google.com>
|
Hey Randy - I was going to merge this for you this morning but looks like the format build blocks - take a look when you have a few! |
Signed-off-by: Randy Smith <rdsmith@google.com>
* Modified docs and variable names Signed-off-by: Randy Smith <rdsmith@google.com> * Changed name in a couple of neglected files Signed-off-by: Randy Smith <rdsmith@google.com> * Fixed format Signed-off-by: Randy Smith <rdsmith@google.com> * Fix typo Signed-off-by: Randy Smith <rdsmith@google.com> * Changed name of coroutines Signed-off-by: Randy Smith <rdsmith@google.com> * Fixed format Signed-off-by: Randy Smith <rdsmith@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
3 participants
Signed-off-by: Randy Smith rdsmith@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Change name and add documentation for integration coroutines.
Risk Level: Low; just name and comment change.
Testing: //test/integration:integration_test
Docs Changes: No user visible doc change.
Fixes #5686