test: pulling protocol specific test code into protocol-specific test…#5775
Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom Feb 4, 2019
Merged
test: pulling protocol specific test code into protocol-specific test…#5775alyssawilk merged 1 commit intoenvoyproxy:masterfrom
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
Conversation
… files Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
approved these changes
Feb 3, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
I see where you are going with this. :)
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
… files (envoyproxy#5775) (sort of) part of envoyproxy#5638 This and the follow-up should remove a bunch of code from all the integration tests which link http_integration.cc Risk Level: low (test only) Testing: integration tests pass Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(sort of) part of #5638
This and the follow-up should remove a bunch of code from all the integration tests which link http_integration.cc
Risk Level: low (test only)
Testing: integration tests pass
Docs Changes: n/a
Release Notes: n/a