(codec) Increase max_request_headers_kb limit to 64 and add http2 codec checks#5773
Merged
mattklein123 merged 14 commits intoenvoyproxy:masterfrom Feb 5, 2019
Merged
(codec) Increase max_request_headers_kb limit to 64 and add http2 codec checks#5773mattklein123 merged 14 commits intoenvoyproxy:masterfrom
mattklein123 merged 14 commits intoenvoyproxy:masterfrom
Conversation
alyssawilk
reviewed
Jan 31, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Looks good overall - just a few request/suggestions
api/envoy/config/filter/network/http_connection_manager/v2/http_connection_manager.proto
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
(sorry matt I ran rebase without dropping a merge commit :$) |
mattklein123
requested changes
Feb 3, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, few small nits. Thank you!
/wait
Member
There was a problem hiding this comment.
This can be const I think. Can you check to see if any others can be also?
Contributor
Author
There was a problem hiding this comment.
const-ified everything in source :)
aunu53
force-pushed
the
max
branch
2 times, most recently
from
be02d8b to
3eb18af
Compare
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
alyssawilk
approved these changes
Feb 4, 2019
mattklein123
approved these changes
Feb 4, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks! I think will need a master merge to fix OSX.
Signed-off-by: Auni Ahsan <auni@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…ec checks (envoyproxy#5773) Signed-off-by: Auni Ahsan <auni@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Extra http2 codec check hard-coded at 63KB has been removed. Instead, the codec max_request_headers_kb is based on the http conn manager config value, or the default value from codec.h. In addition, change instances of ~max_request_headers_size_kb -> ~max_request_headers_kb. Also, split http2/codec_impl_[fuzz_]test.cc connection testing classes into common util.
Risk Level: Medium, touches codec instantiation which is in a lot of places. (There are a lot of call sites on the codec instantiation so please review carefully in case I plugged the default value somewhere I shouldn't have.)
Part of #5626.