filesystem: path sanity checking for fileReadToEnd().#5765
Merged
htuch merged 3 commits intoenvoyproxy:masterfrom Feb 5, 2019
gsserge:filereadtoend
Merged
filesystem: path sanity checking for fileReadToEnd().#5765htuch merged 3 commits intoenvoyproxy:masterfrom gsserge:filereadtoend
htuch merged 3 commits intoenvoyproxy:masterfrom
gsserge:filereadtoend
Conversation
Do not allow Filesystem::fileReadToEnd() for files in /dev, /proc and /sys. Risk Level: Low Testing: New unit test. Fixes: #3170 Signed-off-by: Sergey Glushchenko <gsserge@gmail.com>
| } | ||
|
|
||
| TEST_F(FileSystemImplTest, fileReadToEndBlacklisted) { | ||
| EXPECT_THROW(Filesystem::fileReadToEnd("/dev/urandom"), EnvoyException); |
Member
There was a problem hiding this comment.
Add tests for /proc and /sys?
Signed-off-by: Sergey Glushchenko <gsserge@gmail.com>
Contributor
Author
|
Updated PR based on the feedback. |
Member
venilnoronha
left a comment
venilnoronha
left a comment
There was a problem hiding this comment.
I think it'd be good to add the same check across other file system operations as well.
Contributor
Author
I mentioned that in in the issue #3170 . Would you prefer that as part of this PR, or in the follow-up? |
htuch
previously approved these changes
Feb 5, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks, sorry I missed his one earlier, can you merge master?
Signed-off-by: Sergey Glushchenko <gsserge@gmail.com>
htuch
approved these changes
Feb 5, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Do not allow Filesystem::fileReadToEnd() for files in /dev, /proc and /sys. Risk Level: Low Testing: New unit test. Fixes: envoyproxy#3170 Signed-off-by: Sergey Glushchenko <gsserge@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not allow Filesystem::fileReadToEnd() for files in
/dev, /proc and /sys.
Risk Level: Low
Testing: New unit test.
Fixes: #3170
Signed-off-by: Sergey Glushchenko gsserge@gmail.com