build: fix cc_wrapper.py treatment of -lc++.#5743
Conversation
I think this was the intended code, I noticed a failure in compile_time_options for envoyproxy#5218. Risk Level: Low Testing: bazel build --config=libc++ //source/exe:envoy-static Signed-off-by: Harvey Tuch <htuch@google.com>
|
@PiotrSikora while working on #5218, I hit this issue where I'd like to add a regression test for this, but I don't seem to be able to rebuild with Can you take a look at this and let me know what your thoughts are? |
PiotrSikora
left a comment
There was a problem hiding this comment.
Yes, this was definitely the intended code. Thanks for digging into this!
I guess this worked fine, because the broken code still removed -lstdc++ from the args, and -lc++ is automatically injected when using -stdlib=lc++, so it's wasn't strictly needed.
I think this was the intended code, I noticed a failure in compile_time_options for envoyproxy#5218. Risk Level: Low Testing: bazel build --config=libc++ //source/exe:envoy-static Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: htuch <htuch@users.noreply.github.com>
I think this was the intended code, I noticed a failure in compile_time_options for envoyproxy#5218. Risk Level: Low Testing: bazel build --config=libc++ //source/exe:envoy-static Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
I think this was the intended code, I noticed a failure in
compile_time_options for
#5218.
Risk Level: Low
Testing: bazel build --config=libc++ //source/exe:envoy-static
Signed-off-by: Harvey Tuch htuch@google.com