Skip to content

envoy: basic spellcheck#5688

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
zuercher:stephan/spell-check
Jan 23, 2019
Merged

envoy: basic spellcheck#5688
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
zuercher:stephan/spell-check

Conversation

@zuercher
Copy link
Member

This risks generating a boat load of merge conflicts, but I finally saw one too many typos. I only directly searched for typos in comments, but in doing so came across the spot where certificate was spelled incorrectly in some SSL code and comments, so I fixed that. One error message containing "cluser" also got fixed.

Risk Level: low
Testing: existing tests
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Stephan Zuercher <zuercher@gmail.com>

Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@mattklein123 mattklein123 self-assigned this Jan 23, 2019
@mattklein123 mattklein123 merged commit 58329ac into envoyproxy:master Jan 23, 2019
@zuercher zuercher deleted the stephan/spell-check branch January 23, 2019 18:25
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Jan 24, 2019
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Dan Zhang <danzh@google.com>
fredlas pushed a commit to fredlas/envoy that referenced this pull request Mar 5, 2019
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants