fix a google string vs std::string issue for easier import#5685
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jan 23, 2019
Merged
fix a google string vs std::string issue for easier import#5685mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
htuch
approved these changes
Jan 22, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Xin says that EXPECT_STREQ, so this looks reasonable, thanks.
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Jan 24, 2019
…y#5685) Signed-off-by: Xin Zhuang <stevenzzz@google.com> Signed-off-by: Dan Zhang <danzh@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…y#5685) Signed-off-by: Xin Zhuang <stevenzzz@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xin Zhuang stevenzzz@google.com
Convert the right hand side log-level string into a raw char* before comparing it with a fmt::string_view (which is fmt::basic_string_view). This change enables templated string implementation to be comparable with fmt::basic_string_view.
Description: compare fmt::string_view to a raw char* in test/server/options_impl_test.cc
Risk Level: LOW
Testing: unit test
[Optional Fixes #Issue]
[Optional Deprecated:]