Start populating QUICHE platform implementation.#5684
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jan 23, 2019
mpwarres:quiche-platform
Merged
Start populating QUICHE platform implementation.#5684htuch merged 1 commit intoenvoyproxy:masterfrom mpwarres:quiche-platform
htuch merged 1 commit intoenvoyproxy:masterfrom
mpwarres:quiche-platform
Conversation
- Add QUICHE spdy_platform and quic_platform build rules. - Prune not yet implemented platform implementation files, to reduce noise. - For partially complete platform implementation files, add "TODO: implement" comments to individual items that still need to be implemented. - Add unit tests for platform APIs that have already been implemented. Signed-off-by: Michael Warres <mpw@google.com>
Contributor
Author
|
FYI @htuch for possible review. @danzh2010 and @juvexp, here is a model for adding QUICHE platform implementation files. |
htuch
approved these changes
Jan 23, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
No complaints (and I always complain ;) )
Contributor
Author
|
Thanks for the review! |
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Jan 24, 2019
Start populating QUICHE platform implementation. Follows on envoyproxy#5548, fleshing out the framework for adding the Envoy implementation of the QUICHE platform (i.e. porting layer). Details: * Add QUICHE spdy_platform and quic_platform build rules. * Prune not yet implemented platform implementation files, to reduce noise. * For partially complete platform implementation files, add "TODO: implement" comments to individual items that still need to be implemented. * Add unit tests for platform APIs that have already been implemented. Risk Level: minimal: code not used yet Testing: unit tests Signed-off-by: Michael Warres <mpw@google.com> Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
Tagging associated issue #2557 |
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Jan 31, 2019
Start populating QUICHE platform implementation. Follows on envoyproxy#5548, fleshing out the framework for adding the Envoy implementation of the QUICHE platform (i.e. porting layer). Details: * Add QUICHE spdy_platform and quic_platform build rules. * Prune not yet implemented platform implementation files, to reduce noise. * For partially complete platform implementation files, add "TODO: implement" comments to individual items that still need to be implemented. * Add unit tests for platform APIs that have already been implemented. Risk Level: minimal: code not used yet Testing: unit tests Signed-off-by: Michael Warres <mpw@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Start populating QUICHE platform implementation. Follows on envoyproxy#5548, fleshing out the framework for adding the Envoy implementation of the QUICHE platform (i.e. porting layer). Details: * Add QUICHE spdy_platform and quic_platform build rules. * Prune not yet implemented platform implementation files, to reduce noise. * For partially complete platform implementation files, add "TODO: implement" comments to individual items that still need to be implemented. * Add unit tests for platform APIs that have already been implemented. Risk Level: minimal: code not used yet Testing: unit tests Signed-off-by: Michael Warres <mpw@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Start populating QUICHE platform implementation.
Follows on #5548, fleshing out the framework for adding the Envoy implementation of the QUICHE platform (i.e. porting layer). Details:
comments to individual items that still need to be implemented.
Signed-off-by: Michael Warres mpw@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Risk Level: minimal: code not used yet
Testing: unit tests
Docs Changes: none
Release Notes: none
[Optional Fixes #Issue]
[Optional Deprecated:]