README.md: Fix Ubuntu package list#5679
Conversation
perlun
force-pushed
the
patch-1
branch
3 times, most recently
from
cef81fe to
c848803
Compare
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for the doc fix. Small comment.
/wait
bazel/README.md
Outdated
There was a problem hiding this comment.
This is very unlikely to work. Formatting changes in each version. You probably need to add instructions on how to install clang-format from the LVM repos like we do in the CI container? https://github.com/envoyproxy/envoy/blob/master/ci/build_container/build_container_ubuntu.sh#L11
There was a problem hiding this comment.
You're right; that's sad, since it makes it much more awkward for the user. I wonder if we can find a clang-format-7-PPA or something...
There was a problem hiding this comment.
FYI, this tripped me up recently, but Ubuntu 18 just released clang-7 in a normal update, so I think on 18 once can now just install clang-format-7, if you want to update the docs to account for that.
There was a problem hiding this comment.
Ah, nice! Thanks a lot, I will.
There was a problem hiding this comment.
There we go @mattklein123, should look more sane now.
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
stale
- `realpath` is now in `coreutils`. Signed-off-by: Per Lundberg <perlun@gmail.com>
- `realpath` is now in `coreutils`. Signed-off-by: Per Lundberg <perlun@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
2 participants
clang-format-7isn't available in 18.04; supposedly,clang-format-6.0can be used instead.realpathis now incoreutils.If we like, we can keep a list for "older Ubuntu versions" also but I think it's more important that the list is up-to-date for latest LTS.