Skip to content

mysql_proxy: access EnvoyException by reference. #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 1 commit into from
Jan 21, 2019
Merged

mysql_proxy: access EnvoyException by reference. #5669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions source/extensions/filters/network/mysql_proxy/mysql_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ int BufferHelper::peekUint8(Buffer::Instance& buffer, uint64_t& offset, uint8_t&
val = buffer.peekLEInt<uint8_t>(offset);
offset += sizeof(uint8_t);
return MYSQL_SUCCESS;
} catch (EnvoyException e) {
} catch (EnvoyException& e) {
// buffer underflow
return MYSQL_FAILURE;
}
Expand All @@ -54,7 +54,7 @@ int BufferHelper::peekUint16(Buffer::Instance& buffer, uint64_t& offset, uint16_
val = buffer.peekLEInt<uint16_t>(offset);
offset += sizeof(uint16_t);
return MYSQL_SUCCESS;
} catch (EnvoyException e) {
} catch (EnvoyException& e) {
// buffer underflow
return MYSQL_FAILURE;
}
Expand All @@ -65,7 +65,7 @@ int BufferHelper::peekUint32(Buffer::Instance& buffer, uint64_t& offset, uint32_
val = buffer.peekLEInt<uint32_t>(offset);
offset += sizeof(uint32_t);
return MYSQL_SUCCESS;
} catch (EnvoyException e) {
} catch (EnvoyException& e) {
// buffer underflow
return MYSQL_FAILURE;
}
Expand Down Expand Up @@ -97,7 +97,7 @@ int BufferHelper::peekLengthEncodedInteger(Buffer::Instance& buffer, uint64_t& o
} else {
return MYSQL_FAILURE;
}
} catch (EnvoyException e) {
} catch (EnvoyException& e) {
// buffer underflow
return MYSQL_FAILURE;
}
Expand Down