transport capture: rename to tap#5666
Merged
mattklein123 merged 4 commits intomasterfrom Jan 23, 2019
Merged
Conversation
This is a rename PR only. It renames the capture transport socket and associated tools to the tap transport socket. It also updates some documentation. In a subsequent PR I'm going to refactor the tap transport socket to use the new common tap framework so that the tap transport socket can be configured via admin, the HTTP tap filter can write to a file, the tap transport socket can have matching, etc. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@htuch I think I got everything but let me know if you see anything missing. I didn't rename the "capture" fuzz tests to "tap" fuzz tests since I don't think it matters, but let me know if you prefer that and I can do that also. |
mattklein123
commented
Jan 21, 2019
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
/retest |
|
🔨 rebuilding |
htuch
reviewed
Jan 23, 2019
| // Sequence of read/write events that constitute a trace on a socket. | ||
| // Multiple Trace messages might be emitted for a given connection ID, with the | ||
| // sink (e.g. file set, network) responsible for later reassembly. | ||
| message Trace { |
Member
There was a problem hiding this comment.
You're probably going to want to move from a "entire connection trace" to a chunked trace for streaming in a later PR.
Member
Author
There was a problem hiding this comment.
Yeah I'm going to be working on the streaming stuff in later PRs for sure.
Signed-off-by: Matt Klein <mklein@lyft.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Jan 24, 2019
This is a rename PR only. It renames the capture transport socket and associated tools to the tap transport socket. It also updates some documentation. In a subsequent PR I'm going to refactor the tap transport socket to use the new common tap framework so that the tap transport socket can be configured via admin, the HTTP tap filter can write to a file, the tap transport socket can have matching, etc. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Dan Zhang <danzh@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Jan 31, 2019
This is a rename PR only. It renames the capture transport socket and associated tools to the tap transport socket. It also updates some documentation. In a subsequent PR I'm going to refactor the tap transport socket to use the new common tap framework so that the tap transport socket can be configured via admin, the HTTP tap filter can write to a file, the tap transport socket can have matching, etc. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Matt Klein <mattklein123@gmail.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
This is a rename PR only. It renames the capture transport socket and associated tools to the tap transport socket. It also updates some documentation. In a subsequent PR I'm going to refactor the tap transport socket to use the new common tap framework so that the tap transport socket can be configured via admin, the HTTP tap filter can write to a file, the tap transport socket can have matching, etc. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rename PR only. It renames the capture transport socket
and associated tools to the tap transport socket. It also updates
some documentation. In a subsequent PR I'm going to refactor the
tap transport socket to use the new common tap framework so that
the tap transport socket can be configured via admin, the HTTP
tap filter can write to a file, the tap transport socket can have
matching, etc.
Risk Level: Low
Testing: Existing tests
Docs Changes: Done
Release Notes: I will add a complete release note when I do the
full refactor in a forthcoming PR.