WIP: POC import of current (incomplete) QUICHE into Envoy.#5431
Closed
mpwarres wants to merge 3 commits intoenvoyproxy:masterfrom
mpwarres:add_quiche
Closed
WIP: POC import of current (incomplete) QUICHE into Envoy.#5431mpwarres wants to merge 3 commits intoenvoyproxy:masterfrom mpwarres:add_quiche
mpwarres wants to merge 3 commits intoenvoyproxy:masterfrom
mpwarres:add_quiche
Conversation
This is primarily to gain understanding of how the import could work, and also to what degree we can start working on Envoy QUICHE platform impl while QUICHE is still being completed. Things learned thus far: - Current QUICHE hosting does not appear to provide a tarball with a stable sha256 hash, which Envoy requires of other external dependencies. This would appear to be a prerequisite/blocker for merging some version of this commit, and (in turn) starting work on QUICHE platform implementation for Envoy. - Bazel genrule hackery seems to work for redirecting QUICHE platform impl includes to files in the Envoy source tree. The form of this is likely to change over time as QUICHE adds its own Bazel buildfiles, and (perhaps) some more ergonomic way of overriding include directives for platform implementation files. Signed-off-by: Michael Warres <mpw@google.com>
…che/. Signed-off-by: Michael Warres <mpw@google.com>
Member
|
Very exciting. :) |
Contributor
Author
|
This is superseded by #5548, which imports all QUICHE files (not just http2 ones), and from a static tarball. |
Member
|
Cool will close this out then. So excited for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for submitting in current form. This is primarily to gain understanding of how the
import could work, and also to what degree we can start working on Envoy QUICHE
platform impl while QUICHE is still being completed. (The QUICHE platform impl
included in this PR is a mostly empty one.)
Things learned thus far:
Current QUICHE hosting on googlesource.com does not appear to provide a tarball
with a stable sha256 hash, which Envoy requires of other external dependencies.
This would appear to be a prerequisite/blocker for merging some version of this
commit, and (in turn) starting work on QUICHE platform implementation for Envoy.
Bazel genrule hackery seems to work for redirecting QUICHE platform impl
includes to files in the Envoy source tree. The form of this is likely to
change over time as QUICHE adds its own Bazel buildfiles, and (perhaps) some
more ergonomic way of overriding include directives for platform
implementation files.
Signed-off-by: Michael Warres mpw@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: POC import of current (incomplete) QUICHE into Envoy.
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]