Skip to content

tls: Refactor the ssl socket test #5402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 37 commits into from
Dec 27, 2018
Merged

tls: Refactor the ssl socket test #5402

Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f9b88fd
refactor testUtil to use TestUtilOptions as the parameter
vadimeisenbergibm Dec 22, 2018
9e5f58d
fix a comment
vadimeisenbergibm Dec 22, 2018
5096509
fix a parameter: local uri instead of just uri
vadimeisenbergibm Dec 22, 2018
66864b5
expectedURI -> expectedClientCertURI
vadimeisenbergibm Dec 22, 2018
4138679
expectedStats() -> expectedServerStats()
vadimeisenbergibm Dec 22, 2018
9efab49
refactor: extract TestUtilOptionsBase
vadimeisenbergibm Dec 22, 2018
6868676
add TestUtilOptionsV2 and use them in testUtilV2()
vadimeisenbergibm Dec 22, 2018
fde7ccc
switch client and server stats in the constructor of TestUtilOptionsV2
vadimeisenbergibm Dec 22, 2018
1507362
use TestUtilOptionsV2 to call testUtilV2() in two calls to testUtilV2()
vadimeisenbergibm Dec 22, 2018
05f85c5
call setter methods before call to testUtilV2()
vadimeisenbergibm Dec 23, 2018
53bbe1e
remove redundant parenthesis
vadimeisenbergibm Dec 23, 2018
334c2c0
Revert "remove redundant parenthesis"
vadimeisenbergibm Dec 23, 2018
bcbbe9d
Revert "call setter methods before call to testUtilV2()"
vadimeisenbergibm Dec 23, 2018
f02bdb8
check statistics before calling dispatcher.exit()
vadimeisenbergibm Dec 23, 2018
c43b76f
move checking statistics immediately after dispatcher.exit
vadimeisenbergibm Dec 23, 2018
2090ae3
Revert "move checking statistics immediately after dispatcher.exit"
vadimeisenbergibm Dec 23, 2018
9ccec68
capture client and server stats by copy
vadimeisenbergibm Dec 23, 2018
cc9a9c5
use copy instead of reference for client/server stats
vadimeisenbergibm Dec 23, 2018
55a3218
Revert "use copy instead of reference for client/server stats"
vadimeisenbergibm Dec 23, 2018
0561555
Revert "capture client and server stats by copy"
vadimeisenbergibm Dec 23, 2018
dd2739c
Revert "Revert "move checking statistics immediately after dispatcher…
vadimeisenbergibm Dec 23, 2018
b28ed80
Revert "move checking statistics immediately after dispatcher.exit"
vadimeisenbergibm Dec 23, 2018
e81833b
Revert "check statistics before calling dispatcher.exit()"
vadimeisenbergibm Dec 23, 2018
01e924e
Revert "Revert "call setter methods before call to testUtilV2()""
vadimeisenbergibm Dec 23, 2018
fdf8e08
Revert "Revert "remove redundant parenthesis""
vadimeisenbergibm Dec 23, 2018
f4988ad
Revert "remove redundant parenthesis"
vadimeisenbergibm Dec 23, 2018
03e73f8
Revert "call setter methods before call to testUtilV2()"
vadimeisenbergibm Dec 23, 2018
3eb3d0f
hold expected_client_stats by value and not by reference
vadimeisenbergibm Dec 23, 2018
e646c34
replace more calls to testUtilV2(...) with calls to testUtilV2(TestUt…
vadimeisenbergibm Dec 23, 2018
77df00b
replace all calls to testUtilV2(...) with calls to testUtilV2(TestUti…
vadimeisenbergibm Dec 23, 2018
b385654
add 'set' prefix to setter methods
vadimeisenbergibm Dec 26, 2018
b112dfe
add setExpectedClientStats/ServerStats()
vadimeisenbergibm Dec 26, 2018
79a601d
remove expectedClientCertURI() from TestUtilOptionsV2
vadimeisenbergibm Dec 26, 2018
904b224
clientCtxYAML -> clientCtxYaml
vadimeisenbergibm Dec 26, 2018
4c1b988
URI -> Uri in function names
vadimeisenbergibm Dec 26, 2018
7360856
do not pass server and client stats as parameters in constructors
vadimeisenbergibm Dec 26, 2018
051e1ac
true -> false for FailedClientCertificateHashVerificationNoClientCert…
vadimeisenbergibm Dec 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading