-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add initial OpenCensus tracing support. #5387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e517ebf
de6b334
0c17e0a
461d9b0
0bcaf23
ec0f25d
2f0d285
d96f105
0e28684
e54cadb
1081de3
471dc28
e5d3b9a
c5d46f4
7e444e3
0902d7d
710a6a4
886bccb
06e0d1e
bd901c5
024611d
8f0a4ff
916b860
a984a60
38a19c6
78d3320
16a3e3d
16d9939
cdc9b3c
7bbdce8
b19efcb
9a1c637
cd0486b
85d4e77
93846d4
a9e19df
40f4308
ec14fd5
d65ebb0
e17a406
f7a90b3
8eea063
26853eb
0afc3eb
e5c743e
9efab49
fd739ca
19dbc58
1c56a62
c06ae5f
a7f53f2
5b78b82
6a3e7db
0b0f6df
8ab8440
db9f80f
199a060
f2ca81e
6ccab02
1fb1b9c
142a386
ee4d4d0
41f7dff
bbaca7f
7d07e53
a4e7038
4719582
154b58c
88e6a19
f587ee8
b87a8e1
9ca882f
c8fc2c9
03df4ad
2d9e96b
9d89449
4e3245c
4122637
3b9ced4
7385873
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- lightstep-tracer-common/BUILD 2019-05-29 13:04:55.651083767 -0700 | ||
| +++ lightstep-tracer-common/BUILD 2019-05-29 13:04:59.711080560 -0700 | ||
| @@ -2,7 +2,7 @@ | ||
| name = "collector_proto", | ||
| srcs = ["collector.proto"], | ||
| deps = [ | ||
| - "@lightstep_vendored_googleapis//:googleapis_proto", | ||
| + "@googleapis//:http_api_protos_proto", | ||
| "@com_google_protobuf//:timestamp_proto", | ||
| ], | ||
| visibility = ["//visibility:public"], |
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,52 @@ | ||||||||||||
| --- copts.bzl 2019-06-03 16:42:49.752903373 -0700 | ||||||||||||
htuch marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||
| +++ opencensus/copts.bzl 2019-06-03 16:43:58.136847278 -0700 | ||||||||||||
| @@ -22,25 +22,25 @@ | ||||||||||||
| """ | ||||||||||||
|
|
||||||||||||
| load( | ||||||||||||
| - "@com_google_absl//absl:copts/GENERATED_copts.bzl", | ||||||||||||
| - "ABSL_GCC_FLAGS", | ||||||||||||
| - "ABSL_GCC_TEST_FLAGS", | ||||||||||||
| - "ABSL_LLVM_FLAGS", | ||||||||||||
| - "ABSL_LLVM_TEST_FLAGS", | ||||||||||||
| - "ABSL_MSVC_FLAGS", | ||||||||||||
| - "ABSL_MSVC_TEST_FLAGS", | ||||||||||||
| + "@com_google_absl//absl:copts.bzl", | ||||||||||||
| + "GCC_FLAGS", | ||||||||||||
| + "GCC_TEST_FLAGS", | ||||||||||||
| + "LLVM_FLAGS", | ||||||||||||
| + "LLVM_TEST_FLAGS", | ||||||||||||
| + "MSVC_FLAGS", | ||||||||||||
| + "MSVC_TEST_FLAGS", | ||||||||||||
| ) | ||||||||||||
|
|
||||||||||||
| WERROR = ["-Werror=return-type", "-Werror=switch"] | ||||||||||||
|
|
||||||||||||
| DEFAULT_COPTS = select({ | ||||||||||||
| - "//opencensus:llvm_compiler": ABSL_LLVM_FLAGS + WERROR, | ||||||||||||
| - "//opencensus:windows": ABSL_MSVC_FLAGS, | ||||||||||||
| - "//conditions:default": ABSL_GCC_FLAGS + WERROR, | ||||||||||||
| + "//opencensus:llvm_compiler": LLVM_FLAGS + WERROR, | ||||||||||||
| + "//opencensus:windows": MSVC_FLAGS, | ||||||||||||
| + "//conditions:default": GCC_FLAGS + WERROR, | ||||||||||||
| }) | ||||||||||||
|
|
||||||||||||
| TEST_COPTS = DEFAULT_COPTS + select({ | ||||||||||||
| - "//opencensus:llvm_compiler": ABSL_LLVM_TEST_FLAGS + WERROR, | ||||||||||||
| - "//opencensus:windows": ABSL_MSVC_TEST_FLAGS, | ||||||||||||
| - "//conditions:default": ABSL_GCC_TEST_FLAGS + WERROR, | ||||||||||||
| + "//opencensus:llvm_compiler": LLVM_TEST_FLAGS + WERROR, | ||||||||||||
| + "//opencensus:windows": MSVC_TEST_FLAGS, | ||||||||||||
| + "//conditions:default": GCC_TEST_FLAGS + WERROR, | ||||||||||||
| }) | ||||||||||||
| --- BUILD 2019-06-03 18:30:58.511651926 -0700 | ||||||||||||
| +++ opencensus/exporters/trace/stackdriver/BUILD 2019-06-03 18:32:38.107571186 -0700 | ||||||||||||
| @@ -28,7 +28,7 @@ | ||||||||||||
| copts = DEFAULT_COPTS, | ||||||||||||
| visibility = ["//visibility:public"], | ||||||||||||
| deps = [ | ||||||||||||
| - "//google/devtools/cloudtrace/v2:tracing_proto", | ||||||||||||
| + "@googleapis//:tracing_proto", | ||||||||||||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [in future we can drop this patch] except for this bit. We have to use a single tracing_proto target to avoid ODR (with lightstep). The long term fix for this is to upgrade googleapis, but first we need to add Python language support for googleapis, but first we need an updated py_proto_library rule in bazel, per: envoy/api/bazel/api_build_system.bzl Lines 23 to 27 in 0739cd6
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See also: grpc/grpc#19183 |
||||||||||||
| "//opencensus/common:version", | ||||||||||||
| "//opencensus/common/internal/grpc:status", | ||||||||||||
| "//opencensus/common/internal/grpc:with_user_agent", | ||||||||||||
Uh oh!
There was an error while loading. Please reload this page.