Rate Limit Configuration: Header value match action#526
Merged
Conversation
Contributor
Author
|
@lyft/network-team |
mattklein123
reviewed
Mar 2, 2017
| * ("header_match", "<descriptor_value>") | ||
|
|
||
|
|
||
| .. _config_http_conn_man_route_table_rate_limit_headers: |
Member
There was a problem hiding this comment.
I think we now have this text in potentially 3 places in the docs. Can we de-dup this and just link to it from all 3 places?
mattklein123
reviewed
Mar 2, 2017
| "enum" : ["header_value_match"] | ||
| }, | ||
| "descriptor_value" : {"type" : "string"}, | ||
| "headers" : { |
Member
There was a problem hiding this comment.
This is also duplicated several times now. Can we de-dup and do a sub-schema check in the ConfigUtility code?
mattklein123
reviewed
Mar 2, 2017
| @@ -0,0 +1,40 @@ | |||
| #include "config_utility.h" | |||
Member
There was a problem hiding this comment.
Did you change any code in config_utility or is it just copy/paste to a new file without any changes?
Member
There was a problem hiding this comment.
OK not a big deal but in the future I would do a separate code move PR, just easier to review.
mattklein123
reviewed
Mar 2, 2017
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
looks good other than small de-dup comments
mattklein123
reviewed
Mar 3, 2017
source/common/json/json_validator.h
Outdated
|
|
||
| class JsonValidator { | ||
| public: | ||
| /* |
Member
There was a problem hiding this comment.
nit: move this comment to class level, you are also missing a '*' in the comment opening.
| HeaderData(const Http::LowerCaseString& name, const std::string& value, const bool is_regex) | ||
| : name_(name), value_(value), regex_pattern_(value_, std::regex::optimize), | ||
| is_regex_(is_regex) {} | ||
| struct HeaderData : public Json::JsonValidator { |
Member
There was a problem hiding this comment.
nit: public inheritance not needed
mattklein123
reviewed
Mar 3, 2017
|
|
||
| descriptor_value | ||
| *(required, string)* The value to use in the descriptor entry. | ||
| :ref:`headers<config_http_conn_man_route_table_route_headers>` |
Member
There was a problem hiding this comment.
nit: newline before this line
mattklein123
approved these changes
Mar 3, 2017
tschroed
pushed a commit
to tschroed/envoy
that referenced
this pull request
Apr 10, 2017
lizan
pushed a commit
to lizan/envoy
that referenced
this pull request
Jun 4, 2020
Signed-off-by: John Plevyak <jplevyak@gmail.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: when the server pointer was moved from being captured in the post init callback to outside of it https://github.com/lyft/envoy-mobile/pull/498/files#diff-b5c0c85b8d3df6960fe582b70fe1c122L112 to https://github.com/lyft/envoy-mobile/pull/498/files#diff-79839c4e6bee0a2fa78e0f8215db7433R64 we introduced the possibility that the captured pointer pointer to an invalid memory address. This PR returns the server capture to inside the callback. Risk Level: med - moving pointer captures from synchronous to inside the event loop Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: when the server pointer was moved from being captured in the post init callback to outside of it https://github.com/lyft/envoy-mobile/pull/498/files#diff-b5c0c85b8d3df6960fe582b70fe1c122L112 to https://github.com/lyft/envoy-mobile/pull/498/files#diff-79839c4e6bee0a2fa78e0f8215db7433R64 we introduced the possibility that the captured pointer pointer to an invalid memory address. This PR returns the server capture to inside the callback. Risk Level: med - moving pointer captures from synchronous to inside the event loop Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This adds a basic documentation about `aigw` CLi recently implemented merged. **Related Issues/PRs (if applicable)** Closes #412 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.