access_log: add newline between JSON log lines#5024
Merged
htuch merged 3 commits intoenvoyproxy:masterfrom Nov 14, 2018
Merged
Conversation
Signed-off-by: Aaltan Ahmad <aa@stripe.com>
Signed-off-by: Aaltan Ahmad <aa@stripe.com>
Contributor
Author
|
@htuch @mattklein123 ptal! |
Contributor
Author
|
Verified manually with this config: |
Signed-off-by: Aaltan Ahmad <aa@stripe.com>
Contributor
Author
|
@htuch changes made! |
This was referenced Nov 29, 2018
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Tack a newline onto the end of all JSON access log lines Risk Level: Low Testing: Every JSON unit test will now check to see that there is one (and only one) newline in a log line Docs Changes: None Release Notes: None Fixes envoyproxy#5018 Signed-off-by: Aaltan Ahmad <aa@stripe.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Tack a newline onto the end of all JSON access log lines
Risk Level:
Low
Testing:
Every JSON unit test will now check to see that there is one (and only one) newline in a log line
Docs Changes:
None
Release Notes:
None
Fixes #5018