build: cleanup ci/.bazelrc.

[PiotrSikora]

Fixes: cp: '/source/.bazelrc' and '/source/ci/.bazelrc' are the same file.

Risk Level: Low
Testing: ./ci/run_envoy_docker.sh './ci/do_circle_ci.sh bazel.dev'
Docs Changes: n/a
Release Notes: n/a

Missed in #4771.

Signed-off-by: Piotr Sikora piotrsikora@google.com

[PiotrSikora]

cc @lizan @htuch @rshriram

[lizan]

I think you'll only see that if you have previously ln -sf created .bazelrc in filter-example. This will result unexpected change in .bazelrc when you try to run clang-tidy locally.

[moderation]

I ran into this recently using Docker to build and posted to Slack. To fix this I had to follow the last line at #4740 (comment)

rm -rf /tmp/envoy-docker-build/

[lizan]

perhaps run cleanup before setting up those files? then you won't see the error.

[PiotrSikora]

rm -rf /tmp/envoy-docker-build/ doesn't fix this issues, bazel cleanup --expunge doesn't fix this issue either... but I found the root cause - build step pollutes local repository, so one also needs to remove the previous copy/link, i.e. rm -f ci/.bazelrc.

[PiotrSikora]

Instead of closing this just yet, perhaps we should cleanup the repository after build completes?

[PiotrSikora]

@lizan PTAL, I verified that it fixes the issue when moving from commit that had ci/.bazelrc created using ln -sf to commit that copies it.