http: inline Accept header#4868
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Oct 27, 2018
Merged
Conversation
Adds Accept to the list of inline headers and use the helper functions where appropriate. Signed-off-by: Snow Pettersen <snowp@squareup.com>
Contributor
Author
|
Totally understandable if we want to wait for #4815 before supporting this (do we want to inline headers only used in extensions?), but i figured since this is already used in the repo it might be reasonable to add. |
lizan
approved these changes
Oct 26, 2018
mattklein123
approved these changes
Oct 27, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
As a standard header I think this is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Accept to the list of inline headers and use the helper functions where appropriate.
Signed-off-by: Snow Pettersen snowp@squareup.com
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a