router: disallow host header removal.#4751
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Oct 17, 2018
Merged
Conversation
This is a followup to envoyproxy#4576. It turns out that we have both the ability to refer to the host header via "host" and ":authority" in HeaderMapImpl, see https://github.com/envoyproxy/envoy/blob/6ac936f2750c39a8b4fb232d6ddc4802f4e6aeee/source/common/http/header_map_impl.cc#L276. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10771. Risk Level: Low Testing: Modified existing unit test and corpus entry added. Signed-off-by: Harvey Tuch <htuch@google.com>
zuercher
approved these changes
Oct 17, 2018
soya3129
pushed a commit
to soya3129/envoy
that referenced
this pull request
Oct 19, 2018
This is a followup to envoyproxy#4576. It turns out that we have both the ability to refer to the host header via "host" and ":authority" in HeaderMapImpl, see https://github.com/envoyproxy/envoy/blob/6ac936f2750c39a8b4fb232d6ddc4802f4e6aeee/source/common/http/header_map_impl.cc#L276. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10771. Risk Level: Low Testing: Modified existing unit test and corpus entry added. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Yang Song <yasong@yasong00.cam.corp.google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #4576. It turns out that we have both the ability to refer to the host header
via "host" and ":authority" in HeaderMapImpl, see
envoy/source/common/http/header_map_impl.cc
Line 276 in 6ac936f
Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10771.
Risk Level: Low
Testing: Modified existing unit test and corpus entry added.
Signed-off-by: Harvey Tuch htuch@google.com