http: removing whitespace when appending x-forwarded-for headers#4671
Merged
alyssawilk merged 5 commits intoenvoyproxy:masterfrom Oct 10, 2018
Merged
http: removing whitespace when appending x-forwarded-for headers#4671alyssawilk merged 5 commits intoenvoyproxy:masterfrom
alyssawilk merged 5 commits intoenvoyproxy:masterfrom
Conversation
…nvoyproxy#3587)" (envoyproxy#3609)" This reverts commit 75ca181 with minor docs edits. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, thanks for the follow up.
| * fault: removed integer percentage support. | ||
| * stream: renamed the `RequestInfo` namespace to `StreamInfo` to better match | ||
| its behaviour within TCP and HTTP implementations. | ||
| * http: no longer adding whitespace when appending X-Forwarded-For headers. **Warning**: this is not |
Member
There was a problem hiding this comment.
Can you alpha order? I think you need to merge master anyway to pick up CI fixes.
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
approved these changes
Oct 10, 2018
aa-stripe
pushed a commit
to aa-stripe/envoy
that referenced
this pull request
Oct 11, 2018
…oyproxy#4671) Risk Level: Medium Testing: updated unit tests Docs Changes: nope Release Notes: called out a warning in the release notes Fixes: envoyproxy#3611 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Aaltan Ahmad <aa@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Medium
Testing: updated unit tests
Docs Changes: nope
Release Notes: called out a warning in the release notes
Fixes: #3611