router: add grpc-retry-on "internal" policy#4644
Merged
mattklein123 merged 7 commits intoenvoyproxy:masterfrom Oct 10, 2018
Merged
router: add grpc-retry-on "internal" policy#4644mattklein123 merged 7 commits intoenvoyproxy:masterfrom
mattklein123 merged 7 commits intoenvoyproxy:masterfrom
Conversation
added 2 commits
October 8, 2018 14:22
This allows configuring a gRPC retry polic which retries on internal (13) responses. Signed-off-by: Snow Pettersen <snowp@squareup.com>
lizan
reviewed
Oct 9, 2018
include/envoy/router/router.h
Outdated
| static const uint32_t RETRY_ON_GRPC_DEADLINE_EXCEEDED = 0x40; | ||
| static const uint32_t RETRY_ON_GRPC_RESOURCE_EXHAUSTED = 0x80; | ||
| static const uint32_t RETRY_ON_GRPC_UNAVAILABLE = 0x100; | ||
| static const uint32_t RETRY_ON_GRPC_INTERNAL = 0x101; |
Contributor
Author
There was a problem hiding this comment.
Ah, good catch. Obvious in hindsight
| Envoy will attempt a retry if the gRPC status code in the response headers is "deadline-exceeded" (4) | ||
|
|
||
| internal | ||
| Envoy will attempt to retry if the gRPC status code in the response headers is "internal" (13) |
Signed-off-by: Snow Pettersen <snowp@squareup.com>
lizan
previously approved these changes
Oct 9, 2018
mattklein123
requested changes
Oct 9, 2018
| deadline-exceeded | ||
| Envoy will attempt a retry if the gRPC status code in the response headers is "deadline-exceeded" (4) | ||
|
|
||
| internal |
Member
There was a problem hiding this comment.
Please add a release note for this.
| static const uint32_t RETRY_ON_GRPC_DEADLINE_EXCEEDED = 0x40; | ||
| static const uint32_t RETRY_ON_GRPC_RESOURCE_EXHAUSTED = 0x80; | ||
| static const uint32_t RETRY_ON_GRPC_UNAVAILABLE = 0x100; | ||
| static const uint32_t RETRY_ON_GRPC_INTERNAL = 0x200; |
Member
There was a problem hiding this comment.
This is going to conflict with your other change, so up to you how you want to sequence this.
added 2 commits
October 9, 2018 18:30
Signed-off-by: Snow Pettersen <snowp@squareup.com>
Signed-off-by: Snow Pettersen <snowp@squareup.com>
added 2 commits
October 9, 2018 18:39
lizan
approved these changes
Oct 10, 2018
mattklein123
approved these changes
Oct 10, 2018
aa-stripe
pushed a commit
to aa-stripe/envoy
that referenced
this pull request
Oct 11, 2018
This allows configuring a gRPC retry polic which retries on internal (13) responses. Signed-off-by: Snow Pettersen <snowp@squareup.com> Signed-off-by: Aaltan Ahmad <aa@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows configuring a gRPC retry policy which retries on internal
(13) responses.
Signed-off-by: Snow Pettersen snowp@squareup.com
Description:
Risk Level: Low
Testing: Added unit test
Docs Changes: Added sub-section to retry-on header
Release Notes: n/a