Update StreamInfo related documentation#4609
Merged
junr03 merged 3 commits intoenvoyproxy:masterfrom Oct 5, 2018
Merged
Conversation
This commit updates the documentation related to the recent rename of RequestInfo to StreamInfo. Signed-off-by: Venil Noronha <veniln@vmware.com>
Signed-off-by: Venil Noronha <veniln@vmware.com>
Signed-off-by: Venil Noronha <veniln@vmware.com>
lizan
approved these changes
Oct 5, 2018
mattklein123
reviewed
Oct 5, 2018
| Returns a :ref:`metadata object <config_http_filters_lua_metadata_wrapper>`. | ||
|
|
||
| requestInfo() | ||
| streamInfo() |
Member
There was a problem hiding this comment.
I didn't realize that we changed the Lua API. This is might be a change that we need to revert if people complain. In general I don't think we can make breaking changes like this but this might be OK since I'm guessing very few people use this. We will see.
Member
There was a problem hiding this comment.
Oops, yeah. I think @ramaraochavali has an idea of it?
Contributor
There was a problem hiding this comment.
We are not using this right now. So good from our side.
Member
There was a problem hiding this comment.
Thanks, @ramaraochavali. @yskopets I hope you're OK with this too.
aa-stripe
pushed a commit
to aa-stripe/envoy
that referenced
this pull request
Oct 11, 2018
Description: This PR updates the documentation related to the recent rename of RequestInfo to StreamInfo. Missed these changes in envoyproxy#4503. Also, see envoyproxy#4500 for further info. Risk Level: Low Testing: N/A Docs Changes: Multiple Release Notes: N/A Signed-off-by: Venil Noronha <veniln@vmware.com> Signed-off-by: Aaltan Ahmad <aa@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the documentation related to the recent rename of
RequestInfotoStreamInfo. Missed these changes in #4503. Also, see #4500 for further info.Risk Level: Low
Testing: N/A
Docs Changes: Multiple
Release Notes: N/A
/cc @mattklein123