Skip to content

test: moving test filters around#4596

Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
alyssawilk:watermark_test
Oct 4, 2018
Merged

test: moving test filters around#4596
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
alyssawilk:watermark_test

Conversation

@alyssawilk
Copy link
Contributor

Moving all our integration test filters to one directory and making AddTrailersStreamFilter depend on PassThroughFilter to avoid a bunch of functions that ::Continue

Risk Level: Low (test only)
Testing: tests still pass.
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alyssawilk alyssawilk merged commit b90fd4b into envoyproxy:master Oct 4, 2018
aa-stripe pushed a commit to aa-stripe/envoy that referenced this pull request Oct 11, 2018
Moving all our integration test filters to one directory and making AddTrailersStreamFilter depend on PassThroughFilter to avoid a bunch of functions that ::Continue

Risk Level: Low (test only)
Testing: tests still pass.
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Aaltan Ahmad <aa@stripe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants