Extend repository_impl() to support overriding the repository location key#4577
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Oct 2, 2018
Merged
Extend repository_impl() to support overriding the repository location key#4577htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
georgi-d
force-pushed
the
repoOverrideKey
branch
from
5da6d81 to
a931ecb
Compare
georgi-d
force-pushed
the
repoOverrideKey
branch
from
a931ecb to
12d1981
Compare
… key - now repository_impl supports overriding the repository location key which can be used to simulate repository aliases - used the new feature for the protobuf_cc repository - it is now posible to override the protobuf repository location on the command line and the build to work correctly Signed-off-by: Georgi Dimitrov <gdimitrov@vmware.com>
georgi-d
force-pushed
the
repoOverrideKey
branch
from
12d1981 to
fa86d42
Compare
htuch
changed the title
htuch
approved these changes
Oct 2, 2018
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks. I assume native.alias doesn't work for external repositories.
Contributor
Author
|
@htuch It cannot. Here is the bazel issue that discusses it: bazelbuild/bazel#3219 |
aa-stripe
pushed a commit
to aa-stripe/envoy
that referenced
this pull request
Oct 11, 2018
… key (envoyproxy#4577) - now repository_impl supports overriding the repository location key which can be used to simulate repository aliases - used the new feature for the protobuf_cc repository - it is now posible to override the protobuf repository location on the command line and the build to work correctly Signed-off-by: Georgi Dimitrov <gdimitrov@vmware.com> Signed-off-by: Aaltan Ahmad <aa@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
which can be used to simulate repository aliases
command line and the build to work correctly
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Risk Level: low
Testing: tested locally with overriding the protobuf repo on the command line
Docs Changes: NA
Release Notes: NA