Skip to content

WiP stats: reduce/remove use of CounterSharedPtr et al in production#44031

Draft
jmarantz wants to merge 35 commits intoenvoyproxy:mainfrom
jmarantz:private-copy-from-pointer
Draft

WiP stats: reduce/remove use of CounterSharedPtr et al in production#44031
jmarantz wants to merge 35 commits intoenvoyproxy:mainfrom
jmarantz:private-copy-from-pointer

Conversation

@jmarantz
Copy link
Copy Markdown
Contributor

@jmarantz jmarantz commented Mar 19, 2026

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

jmarantz added 3 commits March 17, 2026 14:12
@jmarantz
private copy from ptr
c189447 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Merge branch 'main' into private-copy-from-pointer
7ebd670 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
checkout -- //source/... compiles but prometheus is dysfunctional at …
3479026 
…the moment.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 19, 2026

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #44031 was opened by jmarantz.

see: more, trace.

@jmarantz jmarantz mentioned this pull request Mar 19, 2026
Draft
@jmarantz
test/common/stats/... working, //source builds.
226605a 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@ggreenway ggreenway self-assigned this Mar 19, 2026
jmarantz added 7 commits March 19, 2026 23:53
@jmarantz
prometheus stats compile but tests fail
dc0444b 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
reduce use of counters()
25b4814 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Checks that we are on the main thread when freeing stats. Changes some
1a4f804 
test infrastructure and an outstanding issue in thread_local_store to
ensure that this is the case.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Merge branch 'main' into private-copy-from-pointer
d17776e 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
many tests work, a few still fail
cadbc9e 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
move the 'get vectors of stats functions on main thread' to prod -- w…
14cb5f9 
…e do need them for Prometheus if we don't want to do a major refactor of that code, so might as well leave them in prod.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
format
b8e8a45 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Copy Markdown
Contributor Author

jmarantz commented Mar 26, 2026

/retest

jmarantz added 5 commits March 26, 2026 18:22
@jmarantz
In ThreadLocalStore, explicitly clear the container vectors from the …
d705c1c 
…cleanup callback which runs in the main thread.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
remove another post
11a1ddd 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
remove spurious sleep I had injected for debug purposes
c9546d0 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
change reference to Stats::Store::counters() from contrib to Stats::c…
f51bfe1 
…ountersMainThread(store)

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
use foreach to enumerate stats.
6652033 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Copy Markdown
Contributor Author

jmarantz commented Mar 27, 2026

/retest

jmarantz added 7 commits March 27, 2026 13:16
@jmarantz
try to fix mobile.
4db0de2 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
mobile format
63ac760 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
detach tests from stats shared ptr dependence
f3dc31d 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
use the allocator's foreach for the store's iterate functions.
52c9cd8 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
revive dead stats-limit infrastructure for now. That can be removed i…
4ea75af 
…n a separate PR.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
fix access logger stats test w/o GaugeSharedPtr
9835bc4 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
fix tests, clean up refs to SHaredPtr.
033d2f5 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Copy Markdown
Contributor Author

jmarantz commented Mar 30, 2026

/coverage

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 30, 2026

Coverage for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-cncf-pr/44031/coverage/index.html

For comparison, current coverage on main branch is here:

https://storage.googleapis.com/envoy-cncf-postsubmit/main/coverage/index.html

The coverage results are (re-)rendered each time the CI Envoy/Checks (coverage) job completes.

🐱

Caused by: a #44031 (comment) was created by @jmarantz.

see: more, trace.

jmarantz added 4 commits March 31, 2026 00:07
@jmarantz
stats coverage
3ac9ae3 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
prom tests works.
bb94d6b 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
cleanup and msan fix
136a38a 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
don't reference a counter after cleanup
503f14d 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Copy Markdown
Contributor Author

jmarantz commented Mar 31, 2026

/retest

jmarantz added 7 commits April 1, 2026 14:20
@jmarantz
remove all StatSharedPtr from codebase outside of stats.
6c482e8 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Merge branch 'main' into private-copy-from-pointer
7b9f3d2 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
fix ref to shared stat.
6c26071 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
format
23ca023 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
gcc fix
d1925db 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
format
eb0af8e 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
format and cleanup
a28433c 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Copy Markdown
Contributor Author

jmarantz commented Apr 2, 2026

/retest

Note: I cannot repro the CI failures with RBE

@jmarantz
Copy link
Copy Markdown
Contributor Author

jmarantz commented Apr 2, 2026

/retest

@jmarantz
python comment spacing
fd8bca8 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RyanTheOptimist RyanTheOptimist Awaiting requested review from RyanTheOptimist RyanTheOptimist will be requested when the pull request is marked ready for review RyanTheOptimist is a code owner

@abeyad abeyad Awaiting requested review from abeyad abeyad will be requested when the pull request is marked ready for review abeyad is a code owner

@danzh2010 danzh2010 Awaiting requested review from danzh2010 danzh2010 will be requested when the pull request is marked ready for review danzh2010 is a code owner

@agrawroh agrawroh Awaiting requested review from agrawroh agrawroh will be requested when the pull request is marked ready for review agrawroh is a code owner

@mathetake mathetake Awaiting requested review from mathetake mathetake will be requested when the pull request is marked ready for review mathetake is a code owner

@wbpcode wbpcode Awaiting requested review from wbpcode wbpcode will be requested when the pull request is marked ready for review wbpcode is a code owner

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 will be requested when the pull request is marked ready for review mattklein123 is a code owner

@nezdolik nezdolik Awaiting requested review from nezdolik nezdolik will be requested when the pull request is marked ready for review nezdolik is a code owner

@ravenblackx ravenblackx Awaiting requested review from ravenblackx ravenblackx will be requested when the pull request is marked ready for review ravenblackx is a code owner

@zuercher zuercher Awaiting requested review from zuercher zuercher will be requested when the pull request is marked ready for review zuercher is a code owner

@tyxia tyxia Awaiting requested review from tyxia tyxia will be requested when the pull request is marked ready for review tyxia is a code owner

@ggreenway ggreenway Awaiting requested review from ggreenway ggreenway will be requested when the pull request is marked ready for review ggreenway is a code owner

@KBaichoo KBaichoo Awaiting requested review from KBaichoo KBaichoo will be requested when the pull request is marked ready for review KBaichoo is a code owner

@botengyao botengyao Awaiting requested review from botengyao botengyao will be requested when the pull request is marked ready for review botengyao is a code owner

@yanavlasov yanavlasov Awaiting requested review from yanavlasov yanavlasov will be requested when the pull request is marked ready for review yanavlasov is a code owner

@kyessenov kyessenov Awaiting requested review from kyessenov kyessenov will be requested when the pull request is marked ready for review kyessenov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ggreenway ggreenway

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmarantz @ggreenway