dns: switch to callback exception wrapping.#4366
Merged
ggreenway merged 4 commits intoenvoyproxy:masterfrom Sep 7, 2018
Merged
dns: switch to callback exception wrapping.#4366ggreenway merged 4 commits intoenvoyproxy:masterfrom
ggreenway merged 4 commits intoenvoyproxy:masterfrom
Conversation
…yproxy#4307)" This reverts commit 1d34172. Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
@ggreenway and here's the simplified version. I preserved the revert history in the PR to make it easier to review. |
Signed-off-by: Harvey Tuch <htuch@google.com>
ggreenway
approved these changes
Sep 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies #4307, as witnessed in #4346 the fix wasn't quite right and only led to more complexity.
Risk level: Low
Testing: Additional unit tests.